Refactor Component -> ComponentDeprecatedAPI

Summary:
The goal of this diff is to refactor the name of Component to ComponentDeprecatedAPI

Also, I'm introducing a new very simple Component API, this new Component will evolve in the next few diffs and days

changelog: [internal] internal

Reviewed By: sammy-SC

Differential Revision: D41128461

fbshipit-source-id: b6aea08caa609153663cdd4165694cc57b4b76b6

Author: mdvacca

ReactAndroid/src/main/jni/react/cxxcomponents/Component.h

@@ -16,51 +16,14 @@ namespace facebook::react {
 
 class Component {
  public:
-  Component(Tag tag, Props::Shared initialProps)
-      : tag_(tag), props_(std::move(initialProps)) {}
+  Component(Tag tag) : tag_(tag) {}
 
-  virtual ~Component() = default;
-
-  /*
-   * Called for updating component's props.
-   * Receiver must update native view props accordingly changed props.
-   */
-  virtual void updateProps(
-      Props::Shared const &oldProps,
-      Props::Shared const &newProps) = 0;
-
-  /*
-   * Called for mounting (attaching) a child component view inside `self`
-   * component view.
-   * Receiver must add `childComponent` as a sub component.
-   */
-  virtual void mountChildComponent(
-      std::shared_ptr<facebook::react::Component> childComponent,
-      int index){};
+  virtual void updateFloatProp(const std::string &propName, float value) = 0;
 
-  /*
-   * Called for unmounting (detaching) a child component view from `self`
-   * component view.
-   * Receiver must remove `childComponent` from a sub component
-   */
-  virtual void unmountChildComponent(
-      std::shared_ptr<facebook::react::Component> childComponent,
-      int index){};
-
-  /*
-   * Called for updating component's state.
-   * Receiver must update native view according to changed state.
-   */
-  virtual void updateState(){};
-
-  /*
-   * Called when the component is being deleted.
-   */
-  virtual void deleteComponent() = 0;
+  virtual ~Component() = default;
 
  protected:
   Tag tag_ = -1;
-  Props::Shared props_;
 };
 
 } // namespace facebook::react

ReactAndroid/src/main/jni/react/cxxcomponents/ComponentDeprecatedAPI.h

@@ -0,0 +1,61 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include <react/renderer/core/Props.h>
+#include <react/renderer/core/ReactPrimitives.h>
+#include <memory>
+#include <string>
+
+namespace facebook::react {
+
+class ComponentDeprecatedAPI {
+ public:
+  ComponentDeprecatedAPI(Tag tag, Props::Shared initialProps)
+      : tag_(tag), props_(std::move(initialProps)) {}
+
+  virtual ~ComponentDeprecatedAPI() = default;
+
+  /*
+   * Called for updating component's props.
+   * Receiver must update native view props accordingly changed props.
+   */
+  virtual void updateProps(
+      Props::Shared const &oldProps,
+      Props::Shared const &newProps) = 0;
+
+  /*
+   * Called for mounting (attaching) a child component view inside `self`
+   * component view.
+   * Receiver must add `childComponent` as a sub component.
+   */
+  virtual void mountChildComponent(
+      std::shared_ptr<facebook::react::ComponentDeprecatedAPI> childComponent,
+      int index){};
+
+  /*
+   * Called for unmounting (detaching) a child component view from `self`
+   * component view.
+   * Receiver must remove `childComponent` from a sub component
+   */
+  virtual void unmountChildComponent(
+      std::shared_ptr<facebook::react::ComponentDeprecatedAPI> childComponent,
+      int index){};
+
+  /*
+   * Called for updating component's state.
+   * Receiver must update native view according to changed state.
+   */
+  virtual void updateState(){};
+
+ protected:
+  Tag tag_ = -1;
+  Props::Shared props_;
+};
+
+} // namespace facebook::react

ReactAndroid/src/main/jni/react/cxxcomponents/ComponentManager.h

@@ -8,6 +8,7 @@
 #pragma once
 
 #include <react/cxxcomponents/Component.h>
+#include <react/cxxcomponents/ComponentDeprecatedAPI.h>
 #include <react/renderer/core/Props.h>
 
 namespace facebook::react {
@@ -16,10 +17,12 @@ class ComponentManager {
  public:
   ComponentManager() {}
 
-  virtual std::shared_ptr<Component> createComponent(
+  virtual std::shared_ptr<ComponentDeprecatedAPI> createComponent(
       Tag tag,
       Props::Shared initialProps) = 0;
 
+  virtual std::shared_ptr<Component> createComponent(Tag tag) = 0;
+
   virtual ~ComponentManager() = default;
 };
 

ReactAndroid/src/main/jni/react/fabric/CppComponentRegistry.cpp

@@ -6,7 +6,6 @@
  */
 
 #include "CppComponentRegistry.h"
-#include <android/log.h>
 #include <fbjni/fbjni.h>
 #include <jsi/jsi.h>
 #include <react/renderer/componentregistry/ComponentDescriptorRegistry.h>
@@ -22,9 +21,8 @@ CppComponentRegistry::initHybrid(jni::alias_ref<jclass>) {
 }
 
 void CppComponentRegistry::registerNatives() {
-  registerHybrid({
-      makeNativeMethod("initHybrid", CppComponentRegistry::initHybrid),
-  });
+  registerHybrid(
+      {makeNativeMethod("initHybrid", CppComponentRegistry::initHybrid)});
 }
 
 void CppComponentRegistry::addComponentManager(
@@ -44,7 +42,7 @@ CppComponentRegistry::getComponentManager(const std::string &name) const {
   return componentManagerResolver_.getComponentManager(name);
 }
 
-std::shared_ptr<facebook::react::Component>
+std::shared_ptr<facebook::react::ComponentDeprecatedAPI>
 CppComponentRegistry::getComponentInstance(Tag tag) const {
   return components_[tag];
 }
@@ -53,7 +51,7 @@ bool CppComponentRegistry::isRootComponent(std::string name) const {
   return componentManagerResolver_.isRootComponent(name);
 }
 
-std::shared_ptr<facebook::react::Component>
+std::shared_ptr<facebook::react::ComponentDeprecatedAPI>
 CppComponentRegistry::createComponentInstance(
     const std::string &componentName,
     Tag tag,

ReactAndroid/src/main/jni/react/fabric/CppComponentRegistry.h

@@ -14,7 +14,7 @@
 #include <mutex>
 #include <unordered_set>
 
-#include <react/cxxcomponents/Component.h>
+#include <react/cxxcomponents/ComponentDeprecatedAPI.h>
 #include <react/cxxcomponents/ComponentManager.h>
 #include <react/fabric/ComponentRegistryResolver.h>
 
@@ -43,10 +43,11 @@ class CppComponentRegistry : public jni::HybridClass<CppComponentRegistry> {
   std::shared_ptr<facebook::react::ComponentManager> getComponentManager(
       const std::string &name) const;
 
-  std::shared_ptr<facebook::react::Component> getComponentInstance(
+  std::shared_ptr<facebook::react::ComponentDeprecatedAPI> getComponentInstance(
       Tag tag) const;
 
-  std::shared_ptr<facebook::react::Component> createComponentInstance(
+  std::shared_ptr<facebook::react::ComponentDeprecatedAPI>
+  createComponentInstance(
       const std::string &componentName,
       Tag tag,
       Props::Shared initialProps) const;
@@ -56,8 +57,9 @@ class CppComponentRegistry : public jni::HybridClass<CppComponentRegistry> {
  private:
   static jni::local_ref<jhybriddata> initHybrid(jni::alias_ref<jclass>);
   ComponentRegistryResolver componentManagerResolver_{};
-  mutable butter::map<Tag, std::shared_ptr<facebook::react::Component>>
-      components_{};
+  mutable butter::
+      map<Tag, std::shared_ptr<facebook::react::ComponentDeprecatedAPI>>
+          components_{};
 };
 
 } // namespace react