Modules/IOStates: avoid creating an unneeded temporary variable

aesophor · aesophor · commit 255c536afb58 · 2022-02-06T13:33:26.000+08:00
Signed-off-by: Marco Wang &lt;m.aesophor@gmail.com&gt;
diff --git a/src/Modules/IOStates/IOStates.cpp b/src/Modules/IOStates/IOStates.cpp
@@ -342,12 +342,11 @@ void IOStates::maybeInterceptStackCanary(S2EExecutionState *state,
 
     if (hasReachedMain &&
         i.mnemonic == "mov" && i.opStr == "rax, qword ptr fs:[0x28]") {
-        uint64_t canary = reg().readConcrete(Register::X64::RAX);
-        m_canary = canary;
+        m_canary = reg().readConcrete(Register::X64::RAX);
 
         log<WARN>()
             << '[' << hexval(i.address) << "] "
-            << "Intercepted canary: " << hexval(canary) << '\n';
+            << "Intercepted canary: " << hexval(m_canary) << '\n';
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -342,12 +342,11 @@ void IOStates::maybeInterceptStackCanary(S2EExecutionState *state,`
`342`	`342`
`343`	`343`	`if (hasReachedMain &&`
`344`	`344`	`i.mnemonic == "mov" && i.opStr == "rax, qword ptr fs:[0x28]") {`
`345`		`- uint64_t canary = reg().readConcrete(Register::X64::RAX);`
`346`		`- m_canary = canary;`
	`345`	`+ m_canary = reg().readConcrete(Register::X64::RAX);`
`347`	`346`
`348`	`347`	`log<WARN>()`
`349`	`348`	`<< '[' << hexval(i.address) << "] "`
`350`		`- << "Intercepted canary: " << hexval(canary) << '\n';`
	`349`	`+ << "Intercepted canary: " << hexval(m_canary) << '\n';`
`351`	`350`	`}`
`352`	`351`	`}`
`353`	`352`