Merge pull request #8 from SPauly/bug6

fixed #6

Author: SPauly

.vscode/launch.json

@@ -8,7 +8,7 @@
             "name": "(gdb) Starten",
             "type": "cppdbg",
             "request": "launch",
-            "program": "${workspaceFolder}/.vscode/GetIntoCPPAgain.exe",
+            "program": "${workspaceFolder}/GetIntoCPPAgain.exe",
             "args": [],
             "stopAtEntry": true,
             "cwd": "${fileDirname}",

GetIntoCPPAgain.exe

@@ -4,34 +4,35 @@ namespace csv
 {
     //class Row
 
-    Row::Row(std::string_view _row){
+    Row::Row(std::string_view _row)
+    {
         m_StartIterator = 0;
         m_ItemIteratorPos = 0;
-        
+
         do
         {
             m_ItemIteratorPos = _row.find_first_of(",", m_StartIterator);
-            m_data.push_back(_row.substr(m_StartIterator, m_ItemIteratorPos-m_StartIterator));
+            m_data.push_back(std::string(_row.substr(m_StartIterator, m_ItemIteratorPos - m_StartIterator)));
             m_StartIterator = m_ItemIteratorPos + 1;
         } while (m_ItemIteratorPos != std::string::npos);
-
     };
 
     Row::~Row(){};
 
     void Row::add_value(std::string_view _value){
-        m_data.push_back(_value);
+        m_data.push_back(std::string(_value));
     };
 
-    std::string_view Row::getvalue(_HEADER_TYPE& _header) const {
+    std::string_view Row::getvalue(_HEADER_TYPE &_header) const
+    {
         return m_data.at(_header);
     };
     //end class Row
 
     //class Header : public Row
-    
-    Header::Header(std::string_view _row) : Row(_row) 
-    { 
+
+    Header::Header(std::string_view _row) : Row(_row)
+    {
         _header_size = m_data.size();
         _header_ptr = m_data.data();
     };
@@ -45,15 +46,16 @@ namespace csv
             //open csv file
             m_INPUT_FILE.open(*PATH_ptr, std::ios::out);
             m_INPUT_FILE.exceptions(std::ifstream::failbit | std::ifstream::badbit | std::ifstream::eofbit);
-            
+
             //init header of file
-            std::string* tmp_line = new std::string;
+            std::string *tmp_line = new std::string;
             tmp_line->clear();
             std::getline(m_INPUT_FILE, *tmp_line);
             _ptr_header = new Header(*tmp_line);
 
             //init m_content
-            while(m_INPUT_FILE.good()){
+            while (m_INPUT_FILE.good())
+            {
                 tmp_line->clear();
                 std::getline(m_INPUT_FILE, *tmp_line);
                 m_content.push_back(Row(*tmp_line));
@@ -73,22 +75,26 @@ namespace csv
         _csvgood = false;
     }
 
-    #ifdef _DEBUG
-    void CSVParser::print_csv(){
-        for(_HEADER_TYPE i = 0; i < _ptr_header->_header_size; i++ ){
-            std::cout<<_ptr_header->getvalue(i);
-            std::cout<<",";
+#ifdef _DEBUG
+    void CSVParser::print_csv()
+    {
+        for (_HEADER_TYPE i = 0; i < _ptr_header->_header_size; i++)
+        {
+            std::cout << _ptr_header->getvalue(i);
+            std::cout << ",";
         }
-        std::cout<<std::endl;
-        for(_HEADER_TYPE i = 0; i < m_content.size(); i++){
-            for(_HEADER_TYPE i2 = 0; i2 < _ptr_header->_header_size; i2++ ){
-                std::cout<<m_content.at(i2).getvalue(i);
-                std::cout<<",";
+        std::cout << std::endl;
+        for (_HEADER_TYPE i = 0; i < m_content.size(); i++)
+        {
+            for (_HEADER_TYPE i2 = 0; i2 < _ptr_header->_header_size; i2++)
+            {
+                std::cout << m_content.at(i).getvalue(i2);
+                std::cout << ",";
             }
-            std::cout<<std::endl;
+            std::cout << std::endl;
         }
     }
-    #endif
+#endif
     //end CSVParser
 
 } // namespace csv

src/CSVParser.cpp

@@ -3,57 +3,60 @@
 #include <string_view>
 #include <fstream>
 #include <vector>
+
+#ifdef _DEBUG
 #include <iostream>
+#endif
 
 #define _DEBUG
 
 namespace csv
 {
     using _HEADER_TYPE = signed int;
 
-    class Row 
+    class Row
     {
     public:
-        Row()= delete;
+        Row() = delete;
         Row(std::string_view);
         ~Row();
 
         void add_value(std::string_view);
-        std::string_view getvalue(_HEADER_TYPE&) const;
+        std::string_view getvalue(_HEADER_TYPE &) const;
+
     protected:
-        std::vector<std::string_view> m_data; 
+        std::vector<std::string> m_data;
+
     private:
         std::string::size_type m_StartIterator;
         std::string::size_type m_ItemIteratorPos;
     };
 
-    class Header : public Row {
+    class Header : public Row
+    {
     public:
         Header() = delete;
         Header(std::string_view);
 
-    public: 
+    public:
         _HEADER_TYPE _header_size;
-        std::string_view* _header_ptr; 
-
+        std::string *_header_ptr;
     };
 
-
     class CSVParser
     {
     public:
         CSVParser() = delete;
-        CSVParser(const std::string*);
+        CSVParser(const std::string *);
         ~CSVParser();
 
-        //create debug print function here
-    #ifdef _DEBUG
+#ifdef _DEBUG
         void print_csv();
-    #endif
-    
+#endif
+
     public:
         bool _csvgood;
-        Header* _ptr_header;
+        Header *_ptr_header;
 
     private:
         std::ifstream m_INPUT_FILE;

src/CSVParser.h

@@ -8,7 +8,7 @@ class User { //holds the user and is responsible for login, logout and activity
 private:
     csv::CSVParser *mptr_csv_parser;                                    //stores one csv parser for all instances
     bool m_login_flag = false;                                     //flag to indicate wheather user is logged in or not
-    bool m_user_request(const std::string *, const std::string *); //deals with authentification of the user
+    bool m_user_request(const std::string* , const std::string* ); //deals with authentification of the user
 public:
     User();
     ~User();