Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend behavior from pressing the 'Close' button to the 'x' button on the 'Bulk operation progress' pop-up #11944

Open
3 tasks
adinaflorea9 opened this issue May 9, 2023 · 0 comments
Labels
change A change of an existing feature (ticket type) general Not directly concerned with any particular functional section of the application ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application

Comments

@adinaflorea9
Copy link

adinaflorea9 commented May 9, 2023

Problem Description

Ticket #11597 introduced the progress bar for bulk actions and the pop-up 'Bulk operation progress'. In the ticket the behavior for the 'Close' button was covered. However, at the same time that the 'Close' button appears when the bulk action is completed, so does the x button.

However, the behavior for the 'x' button is different - the entities edited remain selected and the grid is not refreshed.

Proposed Change

Extend the behavior implemented for the 'Close' button to the 'x' button.

Added Value/Benefit

  • consistency in regards to the behavior when closing the same pop-up window.

Acceptance Criteria

  • after all entries have been processed and the 'Close' button replaces the 'Cancel', the 'x' button also appears; no success notification is needed after the user clicks the 'x' button, but the directory has to be reloaded;
  • after clicking 'x' and the pop-up is closed, the entries are presented in the same way as when closing the pop-up using the 'Close' button;
  • when the user 'Cancels' the action, confirms the cancellation and then this is represented in the pop-up, the buttons 'Close' and 'x' appear as well; extend in this situation as well the behavior from the 'Close' button to the 'x' button;

Implementation Details

No response

Mockups

No response

Additional Information

No response

@adinaflorea9 adinaflorea9 added change A change of an existing feature (ticket type) vaadin-app Affects the Vaadin application general Not directly concerned with any particular functional section of the application labels May 9, 2023
@adinaflorea9 adinaflorea9 changed the title Test Extend behavior from pressing the 'Close' button to the 'x' button on the 'Bulk operation progress' pop-up May 9, 2023
@adinaflorea9 adinaflorea9 added the ready Issue fulfills the definition of ready and can be implemented label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change A change of an existing feature (ticket type) general Not directly concerned with any particular functional section of the application ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application
Projects
None yet
Development

No branches or pull requests

1 participant