Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump victools/jsonschema-generator to 4.33+ for Option.INLINE_NULLABLE_SCHEMAS #83

Closed
bklp opened this issue Feb 23, 2024 · 0 comments
Closed

Comments

@bklp
Copy link

bklp commented Feb 23, 2024

The generation of nullable types in "definitions"/$defs" is kind of weird. They show up listed in Schemas like this "-nullable" and they are pretty redundant in case there is already non-nullable definition of the same type.

Since victools/jsonschema-generator 4.33.0 there is Option.INLINE_NULLABLE_SCHEMAS to adress this (see https://github.com/victools/jsonschema-generator/blob/main/CHANGELOG.md#4330---2023-11-23).

Because of this I'd recommend bumping the version of victools/jsonschema-generator to 4.33.0 or higher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant