Jsoncpp traits no longer uses deprecated Reader (Thalhammer#357)

kiddigital · prince-chrismc · web-flow · commit b36e8a988613 · 2024-07-28T21:52:59.000-07:00
* Jsoncpp traits no longer uses depricated Reader

* linter changes

---------

Co-authored-by: Christopher McArthur &lt;prince.chrismc@gmail.com&gt;
diff --git a/include/jwt-cpp/traits/open-source-parsers-jsoncpp/traits.h b/include/jwt-cpp/traits/open-source-parsers-jsoncpp/traits.h
@@ -117,8 +117,11 @@ namespace jwt {
 			}
 
 			static bool parse(value_type& val, string_type str) {
-				Json::Reader reader;
-				return reader.parse(str, val);
+				Json::CharReaderBuilder builder;
+				const std::unique_ptr<Json::CharReader> reader(builder.newCharReader());
+
+				return reader->parse(reinterpret_cast<const char*>(str.c_str()),
+									 reinterpret_cast<const char*>(str.c_str() + str.size()), &val, nullptr);
 			}
 
 			static string_type serialize(const value_type& val) {

Original file line number	Diff line number	Diff line change
`@@ -117,8 +117,11 @@ namespace jwt {`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`static bool parse(value_type& val, string_type str) {`
`120`		`- Json::Reader reader;`
`121`		`- return reader.parse(str, val);`
	`120`	`+ Json::CharReaderBuilder builder;`
	`121`	`+ const std::unique_ptr<Json::CharReader> reader(builder.newCharReader());`
	`122`	`+`
	`123`	`+ return reader->parse(reinterpret_cast<const char*>(str.c_str()),`
	`124`	`+ reinterpret_cast<const char*>(str.c_str() + str.size()), &val, nullptr);`
`122`	`125`	`}`
`123`	`126`
`124`	`127`	`static string_type serialize(const value_type& val) {`