ApplyEffect implementation #1688
Draft
+4,177
−1,060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
added
nice new thing ☺
heinezen
force-pushed
the
feature/apply_effect
branch
2 times, most recently
from
fe0e630 to
5b96a18
Compare
heinezen
force-pushed
the
feature/apply_effect
branch
from
03fd671 to
61d409b
Compare
heinezen
force-pushed
the
feature/apply_effect
branch
from
8449c6d to
51416c3
Compare
heinezen
added
the
kevin-rebuild-pl0x
SFTbot
removed
the
kevin-rebuild-pl0x
heinezen
force-pushed
the
feature/apply_effect
branch
3 times, most recently
from
d79f834 to
26bac42
Compare
heinezen
force-pushed
the
feature/apply_effect
branch
from
30c0ef0 to
35d4f37
Compare
heinezen
force-pushed
the
feature/apply_effect
branch
from
35d4f37 to
63bc382
Compare
|
Hey @heinezen , what's the state of this PR? Is it ready-ish or faraway? Maybe you can add some details in here |
heinezen
force-pushed
the
feature/apply_effect
branch
2 times, most recently
from
b1ac0c6 to
a4b8864
Compare
heinezen
added
the
kevin-rebuild-pl0x
SFTbot
removed
the
kevin-rebuild-pl0x
There was a problem hiding this comment.
Copilot reviewed 95 out of 96 changed files in this pull request and generated no comments.
Files not reviewed (1)
- libopenage/curve/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
libopenage/curve/continuous.h:77
- The 'compress' parameter in set_insert is declared but not used; if compression is intended for insertions, consider incorporating this flag into the implementation or removing it to avoid confusion.
void Continuous<T>::set_insert(const time::time_t &t, const T &value, bool /* compress */) {
788cc1f to
9b50696
Compare
heinezen
force-pushed
the
feature/apply_effect
branch
2 times, most recently
from
4279e90 to
6023b34
Compare
heinezen
force-pushed
the
feature/apply_effect
branch
from
6023b34 to
2f0e318
Compare
This allows using 0 in the ID texture as respresentation for "no entity".
heinezen
force-pushed
the
feature/apply_effect
branch
from
635b0f5 to
fd5ea13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Description
Depends on SFTtech/nyan#124