Cache blending #158
Closed
Cache blending #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -312,6 +322,20 @@ bool Terrain::check_tile_position(coord::tile pos) { | |||
|
|
|||
| } | |||
|
|
|||
| void Terrain::modify_tile(coord::tile pos) { | |||
There was a problem hiding this comment.
why is it called modify_tile although it deletes tiles from the cache?
|
It looks ok so far, I'm not sure whether we can boost that a bit more. Did you do some performance tests? |
|
I'm messing around with the gperf branch right now to do some performance testing. It can definitely be improved, especially whenever a new chunk is added. |
zuntrax
added
lang: c++
schets
force-pushed
the
cache-blanding
branch
2 times, most recently
from
e278d7c to
58a07bd
Compare
|
Please rebase this pullreq and maybe rename the |
|
I wonder how github claims to be able to auto-merge this... shouldn't |
schets
force-pushed
the
cache-blanding
branch
2 times, most recently
from
f955e84 to
dd9109e
Compare
schets
force-pushed
the
cache-blanding
branch
from
dd9109e to
2219c4c
Compare
|
fix the indent, rebase, squash, merge! 👍 |
|
will be done in #287 hopefully. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blending data is now cached, implements issue #154.