Skip to content

Fix the data race because progress block is called in non-main queue #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix the data race because progress block is called in non-main queue #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion SDWebImageSwiftUI/Classes/ImageManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public final class ImageManager : ObservableObject {
self.indicatorStatus.isLoading = true
self.indicatorStatus.progress = 0
currentOperation = manager.loadImage(with: url, options: options, context: context, progress: { [weak self] (receivedSize, expectedSize, _) in
// This block may be called in non-main thread
guard let self = self else {
return
}
Expand All @@ -95,7 +96,11 @@ public final class ImageManager : ObservableObject {
progress = 0
}
self.indicatorStatus.progress = progress
self.progressBlock?(receivedSize, expectedSize)
if let progressBlock = self.progressBlock {
DispatchQueue.main.async {
progressBlock(receivedSize, expectedSize)
}
}
}) { [weak self] (image, data, error, cacheType, finished, _) in
guard let self = self else {
return
Expand Down
Loading