Skip to content

Performance enhancement to WebImage/AnimatedImage, to avoid extra query for SDWebImage #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2019
Merged

Performance enhancement to WebImage/AnimatedImage, to avoid extra query for SDWebImage #24

merged 2 commits into from
Oct 24, 2019

Conversation

dreampiggy
Copy link
Collaborator

  • Check the current operation and avoid extra query, this can increase performance, even SDWebImage does not query multiple times
  • Don't need to setNeedsDisplay on SwiftUI representable, because SwfitUI will do this automatically

@dreampiggy dreampiggy merged commit ee8ccc3 into master Oct 24, 2019
@dreampiggy dreampiggy deleted the performance_avoid_multiple_query branch October 24, 2019 04:39
@mjswen0923 mjswen0923 mentioned this pull request Sep 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dreampiggy