Skip to content

Fix issue when using placeholder and entering edit mode, the web url does not get requested #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2019
Merged

Fix issue when using placeholder and entering edit mode, the web url does not get requested #23

merged 1 commit into from
Oct 22, 2019

Conversation

dreampiggy
Copy link
Collaborator

Seems that code does not handle the placeholder case from #20

@dreampiggy dreampiggy added the fix label Oct 22, 2019
@dreampiggy dreampiggy merged commit 806e608 into master Oct 22, 2019
@dreampiggy dreampiggy deleted the fix_placeholder_edit_mode branch October 22, 2019 15:16
@mjswen0923 mjswen0923 mentioned this pull request Sep 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dreampiggy