Skip to content

Remove the fix for EXIF image in WebImage, which is fixed by Apple in iOS 14 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Remove the fix for EXIF image in WebImage, which is fixed by Apple in iOS 14 #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions SDWebImageSwiftUI/Classes/WebImage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,16 @@ public struct WebImage : View {
} else {
cgImage = image.cgImage
}
}
// Case 2: Image with EXIF orientation (only EXIF 5-8 contains bug)
else if [.left, .leftMirrored, .right, .rightMirrored].contains(image.imageOrientation) {
cgImage = image.cgImage
} else {
// Case 2: Image with EXIF orientation (only EXIF 5-8 contains bug)
if [.left, .leftMirrored, .right, .rightMirrored].contains(image.imageOrientation) {
// Fixed by Apple in iOS 14+
if #available(iOS 14.0, watchOS 7.0, tvOS 14.0, *) {
// Do nothing
} else {
cgImage = image.cgImage
}
}
}
// If we have CGImage, use CGImage based API, else use UIImage based API
if let cgImage = cgImage {
Expand Down