Try to solve the SwiftUI bug of rendering EXIF UIImage in WebImage, as well as vector images #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow we use the Image(decorative:) API to grab the CGImage and orientation instead. For vector image, draw vector image into bitmap for rescue
dreampiggy
force-pushed
the
hack_exif_webimage_rendering_aspect_ratio
branch
from
7be32e9 to
0a41337
Compare
…I think SwfitUI will fix this issue in the future and we'd better use UIImage as much as possible
…espond API instead
…port in the future. Currently grab the poster image does not do any performance benefit
… think this should be fixed by SwiftUI team :)
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 75.53% 72.78% -2.76%
==========================================
Files 9 9
Lines 748 823 +75
==========================================
+ Hits 565 599 +34
- Misses 183 224 +41
Continue to review full report at Codecov.
|
dreampiggy
added
apple bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we use the Image(decorative:) API to grab the CGImage and orientation instead. For vector image, draw vector image into bitmap for rescue.
This close #101