Skip to content

Automatically import SDWebImage when user write import SDWebImageSwiftUI #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

dreampiggy
Copy link
Collaborator

This close #99

@dreampiggy
Copy link
Collaborator Author

We already do this for CocoaPods && Carthage user, beucase we add this in SDWebImageSwiftUI.h: https://github.com/SDWebImage/SDWebImageSwiftUI/blob/master/SDWebImageSwiftUI/Module/SDWebImageSwiftUI.h

However, SwiftPM seems suck and can not contains both Swift && Objc code in same target. So I don't add SDWebImageSwiftUI.h into the compile unit.

@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   75.53%   75.53%           
=======================================
  Files           9        9           
  Lines         748      748           
=======================================
  Hits          565      565           
  Misses        183      183           
Flag Coverage Δ
#ios 75.53% <ø> (ø)
Impacted Files Coverage Δ
SDWebImageSwiftUI/Classes/SDWebImageSwiftUI.swift 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fe43a5...7c18cc0. Read the comment docs.

@dreampiggy dreampiggy added swiftpm Swift Package Manager related project Project Setting related labels Apr 14, 2020
@dreampiggy dreampiggy merged commit c255043 into master Apr 14, 2020
@dreampiggy dreampiggy deleted the module_export_sd branch April 14, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project Project Setting related swiftpm Swift Package Manager related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't add a custom header
1 participant