Support to export the PDF data for iOS && macOS. iOS need iOS 11+ for keeping vector format. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… keeping vector format.
dreampiggy
commented
May 12, 2019
| @@ -149,7 +183,7 @@ - (UIImage *)createBitmapPDFWithData:(nonnull NSData *)data pageNumber:(NSUInteg | |||
| return nil; | |||
| } | |||
|
|
|||
| CGPDFBox box = kCGPDFCropBox; | |||
| CGPDFBox box = kCGPDFMediaBox; | |||
There was a problem hiding this comment.
Actually, we should use mediabox for general usage. The PDF with cropbox may contains conflict issue when using on iOS with alignmentInsets. If user want, they can do post-processing using transformer. Or this may become a extra decoding options in the future.
dreampiggy
force-pushed
the
feature_export_pdf_data
branch
3 times, most recently
from
ec544b5 to
d0b5e40
Compare
dreampiggy
force-pushed
the
feature_export_pdf_data
branch
from
d0b5e40 to
c0b3140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR descrition
This PR support to export the vector PDF data, from
UIImage/NSImageinstance. Which keep the original vector data (may loss PDF metadata on iOS only, macOS does not impact).See the result: