Skip to content

Commit 97f85b5

Browse files
committed
Fix the correct naming of context option perferredBitmap to prefersBitmap
1 parent 36eb9b0 commit 97f85b5

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

SDWebImagePDFCoder/Classes/SDImagePDFCoder.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,16 +130,16 @@ - (UIImage *)decodedImageWithData:(NSData *)data options:(SDImageCoderOptions *)
130130
}
131131

132132
NSUInteger pageNumber = 0;
133-
BOOL preferredBitmap = NO;
133+
BOOL prefersBitmap = NO;
134134
CGSize imageSize = CGSizeZero;
135135
BOOL preserveAspectRatio = YES;
136136
// Parse args
137137
SDWebImageContext *context = options[SDImageCoderWebImageContext];
138138
if (context[SDWebImageContextPDFPageNumber]) {
139139
pageNumber = [context[SDWebImageContextPDFPageNumber] unsignedIntegerValue];
140140
}
141-
if (context[SDWebImageContextPDFPerferredBitmap]) {
142-
preferredBitmap = [context[SDWebImageContextPDFPerferredBitmap] boolValue];
141+
if (context[SDWebImageContextPDFPrefersBitmap]) {
142+
prefersBitmap = [context[SDWebImageContextPDFPrefersBitmap] boolValue];
143143
}
144144
if (context[SDWebImageContextPDFImageSize]) {
145145
NSValue *sizeValue = context[SDWebImageContextPDFImageSize];
@@ -154,7 +154,7 @@ - (UIImage *)decodedImageWithData:(NSData *)data options:(SDImageCoderOptions *)
154154
}
155155

156156
UIImage *image;
157-
if (!preferredBitmap && [self.class supportsVectorPDFImage]) {
157+
if (!prefersBitmap && [self.class supportsVectorPDFImage]) {
158158
image = [self createVectorPDFWithData:data pageNumber:pageNumber];
159159
} else {
160160
image = [self createBitmapPDFWithData:data pageNumber:pageNumber targetSize:imageSize preserveAspectRatio:preserveAspectRatio];

SDWebImagePDFCoder/Classes/SDWebImagePDFCoderDefine.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ FOUNDATION_EXPORT SDWebImageContextOption _Nonnull const SDWebImageContextPDFPag
1919
A BOOL value which specify whether we prefer the actual bitmap representation instead of vector representation for PDF image. This is because the UIImage on iOS 11+ (NSImgae on macOS) can use the vector image format, which support dynamic scale without losing any detail. However, for some image processing logic, user may need the actual bitmap representation to manage pixels. Also, for lower firmware on iOS, the `UIImage` does not support vector rendering, user may want to handle them using the same code. (NSNumber)
2020
If you don't provide this value, use NO for default value and prefer the vector format when possible.
2121
*/
22-
FOUNDATION_EXPORT SDWebImageContextOption _Nonnull const SDWebImageContextPDFPerferredBitmap;
22+
FOUNDATION_EXPORT SDWebImageContextOption _Nonnull const SDWebImageContextPDFPrefersBitmap;
2323

2424
#pragma mark - Bitmap Representation Options
2525
/**

SDWebImagePDFCoder/Classes/SDWebImagePDFCoderDefine.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@
88
#import "SDWebImagePDFCoderDefine.h"
99

1010
SDWebImageContextOption _Nonnull const SDWebImageContextPDFPageNumber = @"pdfPageNumber";
11-
SDWebImageContextOption _Nonnull const SDWebImageContextPDFPerferredBitmap = @"pdfPerferredBitmap";
11+
SDWebImageContextOption _Nonnull const SDWebImageContextPDFPrefersBitmap = @"pdfPrefersBitmap";
1212
SDWebImageContextOption _Nonnull const SDWebImageContextPDFImageSize = @"pdfImageSize";
1313
SDWebImageContextOption _Nonnull const SDWebImageContextPDFImagePreserveAspectRatio = @"pdfImagePreserveAspectRatio";

0 commit comments

Comments
 (0)