-
Notifications
You must be signed in to change notification settings - Fork 65
Add MDS adapt option to capVol test #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bobpaw
wants to merge
7
commits into
develop
Choose a base branch
from
apw/capVol_mds_adapt
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5792912
to
537b4e3
Compare
- Add -m option to convert mesh database to MDS during adaptation. This option speeds up adaptation. - This tests the conversion capability. Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
- Replace writeCre with cs.save_file. - Replace ma::adaptVerbose with ma::adapt (the production version). - Remove ma::Input arguments which are just reinforcing the defaults. - If the defaults chagne we shouldn't force using the old ones. - Don't delete old mesh model before adapting. - Change CapstoneModule name. - Reorder mds mesh after conversion. Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
- Disable verify() for non-volume meshes. Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
537b4e3
to
bfb892c
Compare
Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
- gmi_cap.h: add gmi_cap_probe and gmi_cap_load_some functions. - wrap headers and functions requiring C++ into #ifdef __cplusplus. - remove using namespace declarations. - add import with gmodel. - gmi_cap.cc: add using namespace CreateMG. - add Geometry namespace to enums (i.e. VERTEX, EDGE, FACE, REGION). - add gmodel to struct cap_model. - use reinterpret_cast instead of C-style casts. - (gmi_cap_start): handle initialization of static capstonemodule. - (gmi_cap_stop): destruct static capstone module. - (create_cre): uncomment function. - (gmi_cap_probe): add short overload to just get mesh names. - add long overload to get model and mesh contents. - (gmi_register_cap): register create_cre for gmi_load. - (owned_import): uncomment function. - (gmi_cap_load): call gmi_cap_load_some with all mesh names. - (gmi_cap_load_some): add new function to only load specific mesh names. - (gmi_import_cap): add overload to use current geometry. - replace PCU_ALWAYS_ASSERT with if statement and gmi_fail. - test/capLoadSome.cc: add utility to test gmi_cap_load_some. - test/capProbe.cc: add utility to test gmi_cap_probe. - test/CMakeLists.txt: add capLoadSome and capProbe. Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
3d9c856
to
d377593
Compare
- gmi_cap/CMakeLists.txt: update link libraries. - gmi_cap/gmi_cap.h: add function documentation. - add doxygen group Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
- apf_cap/CMakeLists.txt: - apf_cap/apfCAP.h: move MeshCAP definition to apfCAP.cc. - add function documentation. - (hasCAP): new function. - add copyright notice. - fix #include guard name. - remove namespace using declarations. - forward declare arguments. - remove unnecessary #includes. - (createMesh): rename to createCapMesh. - similar to loadMdsMesh, etc - (createCapMesh): add overload using existing gmi_model. - (getCapNative): add function to replace MeshCAP::getMesh functionality. - test/cap*: replace createMesh with createCapMesh. - update #includes now that apf_cap doesn't have anything. - remove using namespace CreateMG::*. - prefer MDBI/GDBI to long names. - apf_cap/apfCAP.cc: reorganize #includes. - add using namespace CreateMG and alias commonly used CreateMG::Mesh (which would also conflict with apf::Mesh). - (hasCAP): add definition. - (MeshCAP): add class definition from apfCAP.h - add ownership of mesh database interface in case we use the gmi_model createCapMesh. - (MeshCAP::MeshCAP): use Capstone get_dimension. - add MeshMG:: namespace where needed. - light reformatting. - (createMesh): remove unused function (with non-existent capMesh* type). - (castEntity): remove unused function. Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MDS adapt option to capVol test
-m
flag to convert mesh to MDS during adapt and back to CRE afterward.ma::adapt
instead ofma::adaptVerbose
.ma::Input
.cap.*
tests that run with MDS.TODO
ma::adapt
instead ofma::adaptVerbose
.Comparison: