-
Notifications
You must be signed in to change notification settings - Fork 24
Added NZ catalog reader #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 54.36% 54.62% +0.25%
==========================================
Files 21 22 +1
Lines 3802 3905 +103
Branches 636 650 +14
==========================================
+ Hits 2067 2133 +66
- Misses 1603 1637 +34
- Partials 132 135 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kenny, thanks for sending the revised pull request. I ran the tests and things seem to work fine. I went through the code today and had a discussion with Bill regarding a few of these changes. Please take a look at my comments, and let me know if you have any questions.
Thanks!
@fabiolsilva I've committed the new yaml file. Thanks |
pyCSEP Pull Request Checklist
Please check out the contributing guidelines for some tips
on making pull requests to pyCSEP.
Fixes issue #(please fill in or delete if not needed).
Type of change:
Please delete options that are not relevant.
Checklist: