Skip to content

Added NZ catalog reader #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2023
Merged

Conversation

KennyGraham1
Copy link
Contributor

@KennyGraham1 KennyGraham1 commented Mar 12, 2023

pyCSEP Pull Request Checklist

Please check out the contributing guidelines for some tips
on making pull requests to pyCSEP.

Fixes issue #(please fill in or delete if not needed).

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (this pull request adds no new code)
  • Unpublished science feature (This may require a science review)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Patch coverage: 63.46% and project coverage change: +0.25 🎉

Comparison is base (e50167f) 54.36% compared to head (6a31474) 54.62%.

❗ Current head 6a31474 differs from pull request most recent head 05995f3. Consider uploading reports for the commit 05995f3 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   54.36%   54.62%   +0.25%     
==========================================
  Files          21       22       +1     
  Lines        3802     3905     +103     
  Branches      636      650      +14     
==========================================
+ Hits         2067     2133      +66     
- Misses       1603     1637      +34     
- Partials      132      135       +3     
Impacted Files Coverage Δ
csep/__init__.py 26.11% <5.26%> (-2.88%) ⬇️
csep/utils/readers.py 46.08% <28.57%> (-0.37%) ⬇️
csep/core/catalogs.py 61.02% <50.00%> (+0.06%) ⬆️
csep/utils/geonet.py 81.57% <81.57%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@fabiolsilva fabiolsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kenny, thanks for sending the revised pull request. I ran the tests and things seem to work fine. I went through the code today and had a discussion with Bill regarding a few of these changes. Please take a look at my comments, and let me know if you have any questions.

Thanks!

@KennyGraham1
Copy link
Contributor Author

@fabiolsilva I've committed the new yaml file. Thanks

@fabiolsilva fabiolsilva merged commit c19ce9f into SCECcode:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants