properly handle forecast with empty catalogs #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wsavran
commented
Apr 1, 2021
wsavran
commented
- fixes what happens to empty catalogs #107
- added ability for empty events to be specified explicitly
- implement storage optimization by allowing for empty catalogs to be omitted so long as final catalog_id = (n_cat - 1)
- added unit tests for catalog reading
- todo: update documentation
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 53.25% 56.83% +3.58%
==========================================
Files 19 19
Lines 3091 3116 +25
Branches 445 451 +6
==========================================
+ Hits 1646 1771 +125
+ Misses 1352 1238 -114
- Partials 93 107 +14
Continue to review full report at Codecov.
|
- fixes SCECcode#107 - added ability for empty events to be specified explicitly - implement storage optimization by allowing for empty catalogs to be omitted so long as final catalog_id = (n_cat - 1) - added unit tests for catalog reading - todo: update documentation
wsavran
force-pushed
the
bill_fix107_load-catalog
branch
from
c5ca273 to
b1f4473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.