Skip to content

Commit 833ec84

Browse files
committed
zeroize_derive: fixup test suite [1.4]
#1270 broke the tests for zeroize_derive, this fixes the expected output of the tests accordingly.
1 parent 8a65644 commit 833ec84

File tree

3 files changed

+17
-13
lines changed

3 files changed

+17
-13
lines changed

zeroize/derive/src/lib.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
use proc_macro2::{Ident, TokenStream};
88
use quote::{format_ident, quote};
99
use syn::{
10-
Attribute, Data, DeriveInput, Expr, ExprLit, Field, Fields, Lit, Meta, Result, Variant,
11-
WherePredicate,
1210
parse::{Parse, ParseStream},
1311
parse_quote,
1412
punctuated::Punctuated,
1513
token::Comma,
1614
visit::Visit,
15+
Attribute, Data, DeriveInput, Expr, ExprLit, Field, Fields, Lit, Meta, Result, Variant,
16+
WherePredicate,
1717
};
1818

1919
/// Name of zeroize-related attributes
@@ -454,7 +454,7 @@ mod tests {
454454
impl ::zeroize::Zeroize for Z {
455455
fn zeroize(&mut self) {
456456
match self {
457-
#[allow(unused_variables)]
457+
#[allow(unused_variables, unused_assignments)]
458458
Z { a, b, c } => {
459459
a.zeroize();
460460
b.zeroize();
@@ -484,7 +484,7 @@ mod tests {
484484
impl ::zeroize::Zeroize for Z {
485485
fn zeroize(&mut self) {
486486
match self {
487-
#[allow(unused_variables)]
487+
#[allow(unused_variables, unused_assignments)]
488488
Z { a, b, c } => {
489489
a.zeroize();
490490
b.zeroize();
@@ -520,7 +520,7 @@ mod tests {
520520
impl ::zeroize::Zeroize for Z {
521521
fn zeroize(&mut self) {
522522
match self {
523-
#[allow(unused_variables)]
523+
#[allow(unused_variables, unused_assignments)]
524524
Z { a, b, c } => {
525525
a.zeroize();
526526
b.zeroize()
@@ -545,7 +545,7 @@ mod tests {
545545
impl<T> ::zeroize::Zeroize for Z<T> where T: MyTrait {
546546
fn zeroize(&mut self) {
547547
match self {
548-
#[allow(unused_variables)]
548+
#[allow(unused_variables, unused_assignments)]
549549
Z(__zeroize_field_0) => {
550550
__zeroize_field_0.zeroize()
551551
}
@@ -574,7 +574,7 @@ mod tests {
574574
use ::zeroize::__internal::AssertZeroize;
575575
use ::zeroize::__internal::AssertZeroizeOnDrop;
576576
match self {
577-
#[allow(unused_variables)]
577+
#[allow(unused_variables, unused_assignments)]
578578
Z { a, b, c } => {
579579
a.zeroize_or_on_drop();
580580
b.zeroize_or_on_drop();

zeroize/src/lib.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -252,10 +252,10 @@ mod x86;
252252

253253
use core::{
254254
marker::{PhantomData, PhantomPinned},
255-
mem::{self, MaybeUninit},
255+
mem::{MaybeUninit, size_of},
256256
num::{
257-
self, NonZeroI128, NonZeroI16, NonZeroI32, NonZeroI64, NonZeroI8, NonZeroIsize,
258-
NonZeroU128, NonZeroU16, NonZeroU32, NonZeroU64, NonZeroU8, NonZeroUsize,
257+
self, NonZeroI8, NonZeroI16, NonZeroI32, NonZeroI64, NonZeroI128, NonZeroIsize, NonZeroU8,
258+
NonZeroU16, NonZeroU32, NonZeroU64, NonZeroU128, NonZeroUsize,
259259
},
260260
ops, ptr,
261261
slice::IterMut,
@@ -269,7 +269,7 @@ use {
269269
};
270270

271271
#[cfg(feature = "std")]
272-
use std::ffi::CString;
272+
use {core::mem, std::ffi::CString};
273273

274274
/// Trait for securely erasing values from memory.
275275
pub trait Zeroize {
@@ -405,7 +405,7 @@ where
405405
// The memory pointed to by `self` is valid for `mem::size_of::<Self>()` bytes.
406406
// It is also properly aligned, because `u8` has an alignment of `1`.
407407
unsafe {
408-
volatile_set(self as *mut _ as *mut u8, 0, mem::size_of::<Self>());
408+
volatile_set(self as *mut _ as *mut u8, 0, size_of::<Self>());
409409
}
410410

411411
// Ensures self is overwritten with the default bit pattern. volatile_write can't be
@@ -436,7 +436,7 @@ impl<Z> ZeroizeOnDrop for Option<Z> where Z: ZeroizeOnDrop {}
436436
impl<Z> Zeroize for [MaybeUninit<Z>] {
437437
fn zeroize(&mut self) {
438438
let ptr = self.as_mut_ptr() as *mut MaybeUninit<u8>;
439-
let size = self.len().checked_mul(mem::size_of::<Z>()).unwrap();
439+
let size = self.len().checked_mul(size_of::<Z>()).unwrap();
440440
assert!(size <= isize::MAX as usize);
441441

442442
// Safety:

zeroize/tests/zeroize_derive.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,7 @@ fn derive_deref() {
318318

319319
#[test]
320320
#[cfg(feature = "alloc")]
321+
#[allow(dead_code)]
321322
fn derive_zeroize_on_drop_generic() {
322323
#[derive(ZeroizeOnDrop)]
323324
struct Y<T: Zeroize>(Box<T>);
@@ -327,6 +328,7 @@ fn derive_zeroize_on_drop_generic() {
327328
}
328329

329330
#[test]
331+
#[allow(dead_code)]
330332
fn derive_zeroize_unused_param() {
331333
#[derive(Zeroize)]
332334
struct Z<T> {
@@ -337,6 +339,7 @@ fn derive_zeroize_unused_param() {
337339
}
338340

339341
#[test]
342+
#[allow(dead_code)]
340343
// Issue #878
341344
fn derive_zeroize_with_marker() {
342345
#[derive(ZeroizeOnDrop, Zeroize)]
@@ -353,6 +356,7 @@ fn derive_zeroize_with_marker() {
353356
}
354357

355358
#[test]
359+
#[allow(dead_code)]
356360
// Issue #878
357361
fn derive_zeroize_used_param() {
358362
#[derive(Zeroize)]

0 commit comments

Comments
 (0)