Skip to content

x509-cert: rename helpers to get_extension/filter_extensions #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

baloo
Copy link
Member

@baloo baloo commented Sep 4, 2024

As noted in #1491, the naming of the helpers to get or filter extensions was confusing.

This also documents the methods and provide examples.

Fixes #1491.

@baloo baloo force-pushed the baloo/x509-cert/rename-get-filter branch from a530253 to d74eaee Compare September 6, 2024 23:11
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to get this merged prior to #1505

@tarcieri tarcieri merged commit 474971e into RustCrypto:master Sep 8, 2024
53 checks passed
@baloo baloo deleted the baloo/x509-cert/rename-get-filter branch September 9, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x509-cert: Rename and document TbsCertificateInner::{get, filter}
3 participants