Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto_box rand version is lagging #271

Closed
anthonyjmartinez opened this issue Feb 9, 2021 · 2 comments
Closed

crypto_box rand version is lagging #271

anthonyjmartinez opened this issue Feb 9, 2021 · 2 comments

Comments

@anthonyjmartinez
Copy link

rand 0.8.0 breaks the crypto_box examples.

This could potentially be resolved with pub extern crate rand to remove any ambiguity with the rand versioning and allow for let mut rng = crypto_box::rand::thread_rng();

blocked PRs from depend bot show the same errors I encountered myself, so I won't regurgitate them here.

@tarcieri
Copy link
Member

tarcieri commented Feb 9, 2021

This upgrade is dependent on a corresponding upgrade to x25519-dalek. See: dalek-cryptography/x25519-dalek#64

Note that we use rand_core both because we don't need anything rand-specific and for supporting no_std.

@tarcieri
Copy link
Member

Fixed in #292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants