New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample correct ogg encapsulation #14

Open

est31 opened this issue Mar 24, 2017 · 1 comment

Labels

libvorbis-parity

Member

est31 commented Mar 24, 2017

See spec section A.2. We don't implement some of the requested features:

we should only pass on samples with absolute granule pos > 0
we should check the absolute granule pos of the last page of a stream, and discard any samples that go beyond the given granule pos

These are required for sample-correctness.

est31 added the libvorbis-parity label

Member Author

est31 commented Nov 11, 2018

The second point is now implemented by commit dbfaae5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment