[macOS] Fixed SupportedStreamConfigRange returns same min_samplerate and max_samplerate
#926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomoyanonymous
force-pushed
the
fix-coreaudio-srrange
branch
from
a5b8ca3
to
ccb70c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS,
Device::supported_output/input_configsreturns multiple configs and they are the same values except formin_samplerateandmax_samplerate. However, the pair of samplerates are always the same value likemin_samplerate:44100, max_samplerate:44100andmin_samplerate:48000, max_samplerate:48000.With this PR,
Device::supported_output/input_configsnow returns a combinedSupportedStreamConfig. I found this problem when I tried to reorder the available streamconfigs depending on the parameter in my application.On MacOS,
Device::default_input/output_configdoes not usecmp_default_heuristics(I guess wasapi&asio are the same), but I hope this could be used in every platform ideally (though this PR does not address the implementation of the default config-related method).Tested on: M1 Macbook Air(2020), macOS 15.0.1