Update bindgen requirement from 0.56 to 0.59 #54
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [bindgen](https://github.com/rust-lang/rust-bindgen) to permit the latest version. - [Release notes](https://github.com/rust-lang/rust-bindgen/releases) - [Changelog](https://github.com/rust-lang/rust-bindgen/blob/master/CHANGELOG.md) - [Commits](rust-lang/rust-bindgen@v0.56.0...v0.59.2) --- updated-dependencies: - dependency-name: bindgen dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
@mitchmindtree can we have this dependency upgraded please ? |
|
I checked that sine/feedback examples worked. I'm happy to merge and publish, but what's the correct version bump for something like this? cc @simlay |
|
@MichaelHills what do the past releases (history) say? |
I mean, if there's not breaking changes to the generated bindings, a patch release seems correct to me. I pulled this PR into patch.crates-io and it worked as expected. Unrelated, the iOS examples didn't work with our without this PR :/ |
|
There used to be issues with bindgen updates due to only one clang-sys being possible, which made the update semver breaking. But both 0.56 and 0.59 use the same clang version so it should be okay. |
Regarding the version bump, I haven't done much Rust for over a year so I'm not familiar with dependency issues in practice. Can there be a problem if multiple dependencies specify different versions of bindgen? I'm assuming the only resolution is to force a particular version and hope that it works across all the dependants? Seems to be the consensus that a bump to 0.2.10 is the way to go? There's no reason to not just land this and then pick the version number? If so let's merge this.
What does this mean? |
Correct. Just to be thorough, I tested that audio works as expected with bevy in their iOS example so this is definitely fine as a patch update. |
|
Thanks a lot @simlay |
Updates the requirements on bindgen to permit the latest version.
Changelog
Sourced from bindgen's changelog.
... (truncated)
Commits
8903264Bump version.7bd2329Add --blocklist-file option (#2097)04f5c07Drop 'static for pub const strings for rustc>1.17302b484Typo fix: "in side" -> "inside"0a24ab3allow custom derives on enums2aed6b0context: Escape the try keyword properlyda3f3a3Avoid case of a self-referential type alias.5785340Don't generate 2^64 byte padding fields on unions9738fb9Avoid transmutef91e1a6Fix separator and treating expressionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)