Skip to content

Commit 75d2a4e

Browse files
committed
wifi: mt76: mt7996: clear stale link state on full reset
After a full chip reset, mac80211 reconfig replays interface, link and channel context setup. mt7996_vif_link_add() short-circuits when the link_id is still marked in mvif->valid_links, a state introduced for postponing link teardown to interface removal. The reset path frees the link structures without clearing those bits, so the replayed setup never re-creates dev_info/bss_info/STA records in the restarted firmware and never re-registers the link wcid, leaving the device inoperative. The reset path also leaks every allocated MLD index: per-link indices and the per-vif group/remap indices are re-allocated from scratch during reconfig, but the old bits stay set in the masks, so repeated full resets exhaust the index space. Clear valid_links in the reset vif iterator and reset the MLD index masks alongside the existing omac_mask clearing. Fixes: ace5d3b ("wifi: mt76: mt7996: improve hardware restart reliability") Fixes: 0881370 ("wifi: mt76: mt7996: Destroy vif active links in mt7996_remove_interface()") Link: https://patch.msgid.link/20260724124813.3961474-26-nbd@nbd.name Signed-off-by: Felix Fietkau <nbd@nbd.name>
1 parent 7e4208e commit 75d2a4e

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

  • drivers/net/wireless/mediatek/mt76/mt7996

drivers/net/wireless/mediatek/mt76/mt7996/mac.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2449,6 +2449,7 @@ mt7996_mac_reset_vif_iter(void *data, u8 *mac, struct ieee80211_vif *vif)
24492449
rcu_assign_pointer(mvif->link[i], NULL);
24502450
kfree_rcu(mlink, rcu_head);
24512451
}
2452+
mvif->valid_links = 0;
24522453
rcu_read_unlock();
24532454
}
24542455

@@ -2483,6 +2484,8 @@ mt7996_mac_full_reset(struct mt7996_dev *dev)
24832484

24842485
mt7996_for_each_phy(dev, phy)
24852486
phy->omac_mask = 0;
2487+
dev->mld_idx_mask = 0;
2488+
dev->mld_remap_idx_mask = 0;
24862489

24872490
ieee80211_iterate_stations_atomic(hw, mt7996_mac_reset_sta_iter, dev);
24882491
mt76_reset_device(&dev->mt76);

0 commit comments

Comments
 (0)