Skip to content

Commit 4d8cfff

Browse files
nbd168jmberg-intel
authored andcommitted
wifi: mac80211: skip default WMM setup for AP_VLAN links
AP_VLAN interfaces are never passed to the driver, so setting default WMM parameters on their links trips the check-sdata-in-driver warning in drv_conf_tx(), as well as in the BSS_CHANGED_QOS link info notification. Skip it, matching the existing AP_VLAN handling in this function. Fixes: 2259d14 ("wifi: mac80211: set default WMM parameters on all links") Signed-off-by: Felix Fietkau <nbd@nbd.name> Link: https://patch.msgid.link/20260804082608.2011433-1-nbd@nbd.name Signed-off-by: Johannes Berg <johannes.berg@intel.com>
1 parent 00c786a commit 4d8cfff

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

net/mac80211/link.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,8 @@ static int ieee80211_vif_update_links(struct ieee80211_sub_if_data *sdata,
360360
link = links[link_id];
361361
ieee80211_link_init(sdata, link_id, &link->data, &link->conf);
362362
ieee80211_link_setup(&link->data);
363-
ieee80211_set_wmm_default(&link->data, true, non_sta);
363+
if (sdata->vif.type != NL80211_IFTYPE_AP_VLAN)
364+
ieee80211_set_wmm_default(&link->data, true, non_sta);
364365
}
365366

366367
if (new_links == 0)

0 commit comments

Comments
 (0)