Skip to content

Replace ~"string" with "string.to_owned()", except in fail!, where it wa... #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2014

Conversation

gmorenz
Copy link
Contributor

@gmorenz gmorenz commented May 3, 2014

Replace ~"string" with "string.to_owned()", except in fail!, where it was changed to "string"

@jcmoyer
Copy link
Contributor

jcmoyer commented May 3, 2014

Is to_owned() expected to stay around despite having the box keyword?

@gmorenz
Copy link
Contributor Author

gmorenz commented May 3, 2014

I don't know if it will long term but my understanding is that is currently the case. Currently the code won't compile with ~ or box because of rust-lang/rust#13877

@jcmoyer
Copy link
Contributor

jcmoyer commented May 3, 2014

+1 from me.

@netvl
Copy link
Contributor

netvl commented May 4, 2014

@jcmoyer yes, it will stay, because box "abcd" gives ~&str which is rather useless.

@AngryLawyer
Copy link
Member

Thanks :D

AngryLawyer added a commit that referenced this pull request May 5, 2014
Replace ~"string" with "string.to_owned()", except in fail!, where it wa...
@AngryLawyer AngryLawyer merged commit 4a306e3 into Rust-SDL2:master May 5, 2014
jagprog5 pushed a commit to jagprog5/rust-sdl2 that referenced this pull request Feb 8, 2025
This change adds all the bindings required to apply textures in fragment
shaders with the GPU module, and a new gpu-texture example to
demonstrate them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants