Python Versioning #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implements PackageVersion struct which allows parsing of a python pep-440 version string
- Added package_version to main
- Added PostHead & PostHeader - Finished Post Version Parsing
- Added More tests
- Added DevHead - Finished Dev Version processing - Realized that local version can be +<anything>.<anything>.<anything> and so on
- Ran cargo fmt - Added v1.1 unit test - Made negative unit test fail more spesific
- Implemented equality - Added equality unit-tests
- Changed DevHead to struct from enum - Added Ordering for Dev
- Finished Post Ordering - Added Post Ordering Unit tests
- Ran cargo fmt - Finished Pre Version Ordering - Added Pre Version unit tests
- Renamed VersionRelease to ReleaseHeader - Added ReleaseHeader unit tests
- Finished All Ordering
- Added PackageVersion doc-strings - Made ReleaseHeader Unit test more verbose
- Added doc strings - Added usage example
- Ran clippy - Ran fmt - Ran test
Added some more comments for clarity
|
@Allstreamer in lines 133 and 134, where are |
|
Ah misread the question at first |
|
My IDE cannot resolve lines 133 and 134 in your code for some reason |
|
Check main.rs & Cargo.toml. There their usage is denfined |
|
You forgot to include all changes In your branch |
Allstreamer
added a commit
that referenced
this pull request
Aug 15, 2022
- Moved changes from #20 to 25-add-python-version-parsing-pep-440 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Equality and Ordering Operations for Python Pep-440 Versions as described in the image below:
Intergrates very nicely with @Kiwifuit's #18 Where His version requirement code can be supplemented by my system