Assorted cleanups #446
Merged
Assorted cleanups #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`parsing_error` reads strangely. `parse_error` is much more normal.
- The first `@single_rule` rule just repeats the contents of the subsequent four `@single_rule` rules. So just call them. - The subsequent four `@single_rule` rules don't need to handle repetition, because the first rule handles that.
nnethercote
requested review from
Firestar99,
LegNeato,
eddyb and
schell
as code owners
Firestar99
reviewed
Oct 21, 2025
There was a problem hiding this comment.
Looking good, just some minor things. It'll conflict with #447 on the compiletests blessings, but that's a minor fixup.
|
Ok, two of the commits were removed based on @Firestar99's feedback. |
Firestar99
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted cleanups I found while reading through this code.