Implement for for signed integers
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fee1-dead
requested review from
eddyb,
LegNeato and
fornwall
as code owners
fee1-dead
force-pushed
the
signed-for
branch
from
f286143
to
e6f1004
Compare
|
Thanks a lot for making this, cause I barely know anything about rustc dev and would have probably spend days trying to make something work :D |
fee1-dead
commented
Sep 22, 2024
fee1-dead
force-pushed
the
signed-for
branch
from
e6f1004
to
891eed6
Compare
|
This looks great, thanks! I've invited you to our private maintainer zulip as you have more experience with rustc than the rest of us....feel free to decline if you aren't interested! We're also beefing up the number of maintainers so if you'd be interested ping me on zulip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best viewed commit-by-commit.