Support CI tests for old rust-gpu versions#41
Conversation
tombh
force-pushed
the
support-ci-testing-old-rust-gpu-versions
branch
from
36394d5 to
0e50a9b
Compare
|
BTW I streamed a lot of the development of this PR on Twitch 🤓 https://www.twitch.tv/videos/2365066223 |
tombh
force-pushed
the
support-ci-testing-old-rust-gpu-versions
branch
2 times, most recently
from
23ab263 to
a27320a
Compare
tombh
force-pushed
the
support-ci-testing-old-rust-gpu-versions
branch
2 times, most recently
from
22389d6 to
ad2397d
Compare
|
This is ready for review. There's still a couple of TODOs, but they're not high priority. |
|
@tombh do you want me to clear up these conflicts, since I ultimately caused them? |
|
Aww, thanks for the offer! Very kind of you 😊 I was actually more interested in a review at the moment. Then I could make any changes and resolve the conflicts at once. |
tombh
force-pushed
the
support-ci-testing-old-rust-gpu-versions
branch
4 times, most recently
from
88ddf23 to
a14356d
Compare
|
Done, and requested another review. Do you get the review request independently? |
tombh
force-pushed
the
support-ci-testing-old-rust-gpu-versions
branch
2 times, most recently
from
e230414 to
edb706a
Compare
I do! I get them in my notifications, which I have to actively check because GitHub tends to be pretty spammy with email. |
Adds `rust-gpu` versions, `0.8.0` and `0.9.0` to the Linux matrix on CI tests. `0.7.0` has a probably minor dependency error, but it's also 18 months old and there probably aren't many users of it. Notes: * Adds a version arg to, eg: `cargo xtask --rust-gpu-version 0.8.0`. * Offers a new CLI arg to workaround a bug where conflicting v3/v4 versions of `Cargo.lock` files (between the shader and workspace) cause a build error. See `force_overwrite_lockfiles_v4_to_v3` arg.
tombh
force-pushed
the
support-ci-testing-old-rust-gpu-versions
branch
from
edb706a to
9de5c78
Compare
schell
left a comment
schell
left a comment
There was a problem hiding this comment.
The code looks good to me. I'm going to check it out locally and see if it builds my project. Tentative approval already given.
Great work!
|
Your branch builds my project just fine! Sweet as! Feel free to merge when you're ready. |
2 participants
Adds
rust-gpuversions,0.8.0and0.9.0to the Linux matrix on CI tests.0.7.0has a probably minor dependency error, but it's also 18 months old and there probably aren't many users of it.Notes:
just build-shader-template 0.8.0.Cargo.lockfiles (between the shader and workspace) cause a build error. Seeforce_overwrite_lockfiles_v4_to_v3argspirv-stdin theshader-crate-template.TODO:
Cargo.lockfiles that need to be reverted. This will allow reverting them even if the build fails.Cargo.lockmanifest version conflict. It would require having a sample shader crate with a Rust toolchain is < 1.83.0.