Skip to content

Commit fdccb76

Browse files
Better names for test methods
1 parent 51e9295 commit fdccb76

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

cardinal_pythonlib/tests/extract_text_tests.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def test_csv_converted(self) -> None:
130130

131131
self.assertEqual(text, content)
132132

133-
def test_doc_converted_with_antiword(self) -> None:
133+
def test_doc_will_be_converted_with_antiword(self) -> None:
134134
with mock.patch.multiple(
135135
"cardinal_pythonlib.extract_text.subprocess",
136136
Popen=self.mock_popen,
@@ -152,7 +152,7 @@ def test_doc_converted_with_antiword(self) -> None:
152152
]
153153
self.mock_popen.assert_has_calls(expected_calls)
154154

155-
def test_dot_converted_with_antiword(self) -> None:
155+
def test_dot_will_be_converted_with_antiword(self) -> None:
156156
with mock.patch.multiple(
157157
"cardinal_pythonlib.extract_text.subprocess",
158158
Popen=self.mock_popen,
@@ -233,7 +233,7 @@ def test_odt_converted(self) -> None:
233233

234234
self.assertEqual(text.strip(), content)
235235

236-
def test_pdf_converted(self) -> None:
236+
def test_pdf_will_be_converted_with_pdftotext(self) -> None:
237237
with mock.patch.multiple(
238238
"cardinal_pythonlib.extract_text.subprocess",
239239
Popen=self.mock_popen,
@@ -254,7 +254,7 @@ def test_pdf_converted(self) -> None:
254254
]
255255
self.mock_popen.assert_has_calls(expected_calls)
256256

257-
def test_rtf_converted(self) -> None:
257+
def test_rtf_will_be_converted_with_unrtf(self) -> None:
258258
with mock.patch(
259259
"cardinal_pythonlib.extract_text.UNRTF_SUPPORTS_QUIET", True
260260
):
@@ -561,7 +561,7 @@ def test_eml_invalid_surrogate_characters_replaced(self) -> None:
561561

562562
self.assertEqual(text.strip(), "??")
563563

564-
def test_unsupported_converted(self) -> None:
564+
def test_unsupported_will_be_converted_with_strings(self) -> None:
565565
with mock.patch.multiple(
566566
"cardinal_pythonlib.extract_text.subprocess",
567567
Popen=self.mock_popen,

0 commit comments

Comments
 (0)