Skip to content

Commit f427974

Browse files
authored
Merge pull request #1 from giovannipessiva/master
Fix renaming regression and minor typo
2 parents dddbf6f + a27ef5c commit f427974

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,5 @@ An Eclipse plug-in for developing in the TypeScript language.
4747
* Run `update_version.sh old_version new_version` This is to change all version ".qualifier"
4848
* Run `npm install`
4949
* Run `grunt`
50-
* Run `maven package`
50+
* Run `mvn package`
5151
* Install zip in Eclipse following `Install New Software...` -> `Add...` -> `Archive...`

com.palantir.typescript/src/com/palantir/typescript/services/language/RenameLocation.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,19 @@ public final class RenameLocation {
3232

3333
private final String fileName;
3434
private final TextSpan textSpan;
35+
private final Boolean isDefinition;
3536

3637
public RenameLocation(
3738
@JsonProperty("fileName") String fileName,
38-
@JsonProperty("textSpan") TextSpan textSpan) {
39+
@JsonProperty("textSpan") TextSpan textSpan,
40+
@JsonProperty("isDefinition") Boolean isDefinition) {
3941
checkNotNull(fileName);
4042
checkNotNull(textSpan);
41-
43+
checkNotNull(isDefinition);
44+
4245
this.fileName = fileName;
4346
this.textSpan = textSpan;
47+
this.isDefinition = isDefinition;
4448
}
4549

4650
public String getFileName() {
@@ -50,12 +54,17 @@ public String getFileName() {
5054
public TextSpan getTextSpan() {
5155
return this.textSpan;
5256
}
57+
58+
public Boolean isDefinition() {
59+
return this.isDefinition;
60+
}
5361

5462
@Override
5563
public String toString() {
5664
return Objects.toStringHelper(this)
5765
.add("fileName", this.fileName)
5866
.add("textSpan", this.textSpan)
67+
.add("isDefinition", this.isDefinition)
5968
.toString();
6069
}
6170
}

0 commit comments

Comments
 (0)