Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Priority - Question/Rant - Can't we just prevent assets from breaking at all? #62

Open
jnncoutinho opened this issue Feb 23, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@jnncoutinho
Copy link
Contributor

jnncoutinho commented Feb 23, 2018

Assets break when there are upload errors, i.e., I start uploading the asset, the connection is lost, so the file is corrupted and the asset is broken.

Can't we just wait until the new file comes, check it, validate it, and only then delete and replace the old one?


#region Rant

Our current system is far too fragile. With my home internet I have connection time outs in at least 25% of the uploads I make (now I mostly upload with 4G; it helps a lot). Once, we had such a combination of bad connection and plugin bug that we managed to corrupt both the iOS and the WebGL asset of a prop: the only solution was to create a new asset and have Denis manually remap the IDs so that prop wouldn't disappear from the user's rooms.

A very plausible scenario that could happen even with a better connection that mine: imagine that I am uploading a model to view in HTC Vive. It's a powerful platform, so I'm uploading an extremely heavy asset and won't be uploading anything to other platforms. If my connection craps out or I have a power outage in the middle of a 100MB upload, my asset is destroyed and there's nothing I can do about it. If it's a new asset I can start over, polluting our database with as many broken assets as failed file uploads. If I'm trying to update an existing asset, my only solution is to call Denis and have him remap the IDs.

I can call Denis and I can access the server to clean up after myself, but once we open the plugin to other content producers, that won't be an option for them. We need to make this system more robust. I think issue #58 is a step in that direction, but it doesn't solve assets breaking in the first place. People don't have control over their internet connections, or power outages, or whatever issue may arise that cancels an upload abruptly. We just can't have assets breaking if an upload fails.

#endregion

@jnncoutinho jnncoutinho added this to the Priority milestone Feb 23, 2018
@jnncoutinho jnncoutinho changed the title Question/Rant - Can't we just prevent assets from breaking at all? High Priority - Question/Rant - Can't we just prevent assets from breaking at all? Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants