feat(linalg): add a way to pass controlFn to foldIntoPackUnpackPatterns
#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
egebeysel
force-pushed
the
06-10-feat_linalg_add_a_way_to_pass_controlfn_to_foldintopackunpackpatterns_
branch
from
cf69d3e to
e1447ad
Compare
`foldIntoPackUnpackPatterns`
egebeysel
force-pushed
the
06-10-feat_linalg_add_a_way_to_pass_controlfn_to_foldintopackunpackpatterns_
branch
from
e1447ad to
16dc684
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is step 1/3 of fixing the large vector sizes found compilation failure (roo-389). This PR adds a mechanism, so that downstream consumers can pass in control functions for the application of these patterns. This change shouldn't affect any consumers of this method that do not specify a controlFn.
In IREE, we (will) use it to control preventing folding patterns that would inhibit fusion. See IREE issue llvm#20896 for more details.