[Linalg][Canonicalization] Add Tensor -> Scalar Pattern #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many other patterns and checks within Linalg that define a
scalar to be a single value that is not a single element tensor type.
This blocks certain transforms (LinalgSpecialization) and checks.
Take for example the following:
The generic in question performs a broadcast from a scalar to a tensor.
However, the transforms and checks that identifies this oepration as a
FillOp do not trigger because the definition of a scalar at the input
is one that is not a RankedTensor, rather a single value.
The following change attempts to reconcile this discrepancy by
converting any known operand on a generic to a true scalar. Resulting
in the following: