fix: use model defaultTemperature over provider default in BaseOpenAiCompatibleProvider

Author: roomote

src/api/providers/__tests__/fireworks.spec.ts

@@ -449,16 +449,85 @@ describe("FireworksHandler", () => {
 		)
 	})
 
-	it("should use default temperature of 0.5", () => {
-		const testModelId: FireworksModelId = "accounts/fireworks/models/kimi-k2-instruct"
+	it("should use provider default temperature of 0.5 for models without defaultTemperature", async () => {
+		const modelId: FireworksModelId = "accounts/fireworks/models/kimi-k2-instruct"
 		const handlerWithModel = new FireworksHandler({
-			apiModelId: testModelId,
+			apiModelId: modelId,
 			fireworksApiKey: "test-fireworks-api-key",
 		})
-		const model = handlerWithModel.getModel()
-		// The temperature is set in the constructor as defaultTemperature: 0.5
-		// This test verifies the handler is configured with the correct default temperature
-		expect(handlerWithModel).toBeDefined()
+
+		mockCreate.mockImplementationOnce(() => ({
+			[Symbol.asyncIterator]: () => ({
+				async next() {
+					return { done: true }
+				},
+			}),
+		}))
+
+		const messageGenerator = handlerWithModel.createMessage("system", [])
+		await messageGenerator.next()
+
+		expect(mockCreate).toHaveBeenCalledWith(
+			expect.objectContaining({
+				temperature: 0.5,
+			}),
+			undefined,
+		)
+	})
+
+	it("should use model defaultTemperature (1.0) over provider default (0.5) for kimi-k2-thinking", async () => {
+		const modelId: FireworksModelId = "accounts/fireworks/models/kimi-k2-thinking"
+		const handlerWithModel = new FireworksHandler({
+			apiModelId: modelId,
+			fireworksApiKey: "test-fireworks-api-key",
+		})
+
+		mockCreate.mockImplementationOnce(() => ({
+			[Symbol.asyncIterator]: () => ({
+				async next() {
+					return { done: true }
+				},
+			}),
+		}))
+
+		const messageGenerator = handlerWithModel.createMessage("system", [])
+		await messageGenerator.next()
+
+		// Model's defaultTemperature (1.0) should take precedence over provider's default (0.5)
+		expect(mockCreate).toHaveBeenCalledWith(
+			expect.objectContaining({
+				temperature: 1.0,
+			}),
+			undefined,
+		)
+	})
+
+	it("should use user-specified temperature over model and provider defaults", async () => {
+		const modelId: FireworksModelId = "accounts/fireworks/models/kimi-k2-thinking"
+		const handlerWithModel = new FireworksHandler({
+			apiModelId: modelId,
+			fireworksApiKey: "test-fireworks-api-key",
+			modelTemperature: 0.7,
+		})
+
+		mockCreate.mockImplementationOnce(() => ({
+			[Symbol.asyncIterator]: () => ({
+				async next() {
+					return { done: true }
+				},
+			}),
+		}))
+
+		const messageGenerator = handlerWithModel.createMessage("system", [])
+		await messageGenerator.next()
+
+		// User-specified temperature should take precedence over everything
+		expect(mockCreate).toHaveBeenCalledWith(
+			expect.objectContaining({
+				temperature: 0.7,
+			}),
+			undefined,
+		)
 	})
 
 	it("should handle empty response in completePrompt", async () => {

src/api/providers/base-openai-compatible-provider.ts

@@ -84,7 +84,7 @@ export abstract class BaseOpenAiCompatibleProvider<ModelName extends string>
 				format: "openai",
 			}) ?? undefined
 
-		const temperature = this.options.modelTemperature ?? this.defaultTemperature
+		const temperature = this.options.modelTemperature ?? info.defaultTemperature ?? this.defaultTemperature
 
 		const params: OpenAI.Chat.Completions.ChatCompletionCreateParamsStreaming = {
 			model,