Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix intendation in role model #495

Merged
merged 4 commits into from
Mar 1, 2019
Merged

chore: fix intendation in role model #495

merged 4 commits into from
Mar 1, 2019

Conversation

Neznauy
Copy link
Contributor

@Neznauy Neznauy commented Sep 5, 2018

Hi all,
according to ruby code style, class code should be 1 tab to the right of class definition.
Now it´s not like that in Role model after rails g rolify Role User
now: wnxc-b26gwg
after: l2wtjdxxmvk

@coveralls
Copy link

coveralls commented Sep 5, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 92.516% when pulling 3e73146 on Neznauy:role_model_codestyle into bb3d445 on RolifyCommunity:master.

EppO
EppO requested changes Feb 27, 2019
View reviewed changes
Copy link
Member

@EppO EppO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in the model makes sense as it's more readable this way. OTOH, the spaces in the specs look odd to me

spec/generators/rolify/rolify_activerecord_generator_spec.rb Outdated Show resolved Hide resolved
@EppO EppO merged commit e6d59b0 into RolifyCommunity:master Mar 1, 2019
@EppO
Copy link
Member

EppO commented Mar 1, 2019

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO EppO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neznauy @coveralls @EppO