-
-
Couldn't load subscription status.
- Fork 205
ENH: Improve parachute geometric parametrization #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MateusStano
merged 25 commits into
develop
from
enh/improve-parachute-geometric-parametrization
Sep 15, 2025
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0873d21
ENH: added radius and porosity to parachute
ArthurJWH 02ddd1b
ENH: added parachute radius
ArthurJWH 1119ef8
ENH: fixing radius and height attribute in flight class
ArthurJWH 413503f
STY: ruff formatting
ArthurJWH f09a4b0
TST: updated test value due to gravity update in u_dot_parachute
ArthurJWH 78ef92e
ENH: added new parameters into add_parachute method in Rocket class
ArthurJWH 7defc38
DOC: added new parameters to the documentation
ArthurJWH 465f526
Merge branch 'develop' into enh/improve-parachute-geometric-parametri…
ArthurJWH c5ce166
TST: updated test values to match the right gravity model
ArthurJWH f84459d
DOC: improved descriptions of the new parameters
ArthurJWH 4fcb406
ENH: added new parameters to the stochastic parachute
ArthurJWH 159cce8
ENH: implementing previous comments
ArthurJWH 0c434f8
ENH: fixing formatting and adding docs
ArthurJWH f136ffb
ENH: added ka property to Parachute class
ArthurJWH 112b75a
ENH: fixing variable name
ArthurJWH 40d10c5
ENH: fixed attribute name
ArthurJWH 1e2a2fd
ENH: simplifying variable names
ArthurJWH 65530fd
DOC: adding parameters documentation into StochasticParachute descrip…
ArthurJWH 363bfc8
ENH: changing ma calculation and porosity documentation from previous…
ArthurJWH 53b0940
TST: updated test value due to change in ma calculation
ArthurJWH 87216ca
ENH: changing parameter ka to added_mass_coefficient
ArthurJWH 4f20568
DOC: updating the CHANGELOG
ArthurJWH 68fc191
Merge branch 'develop' into enh/improve-parachute-geometric-parametri…
ArthurJWH 9a03c01
ENH: properly substituted all ka parameters for added_mass_coefficient
ArthurJWH 486a5d1
Merge branch 'enh/improve-parachute-geometric-parametrization' of htt…
ArthurJWH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gui-FernandesBR marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having both
cdsandparachute_radius? do you think we could possible calculate the cd based on these other parameters?