Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fixed AGL altitude in _FlightPrints.events_registered #788

Conversation

L30-stack
Copy link
Contributor

@L30-stack L30-stack commented Mar 19, 2025

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

_FlightPrints.events_registered() prints the AGL altitude at the event trigger time.

New behavior

_FlightPrints.events_registered() prints the AGL altitude at the open parachute time.

Breaking change

  • Yes
  • No

@L30-stack L30-stack requested a review from a team as a code owner March 19, 2025 14:09
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and quick fix!!

Just need to update the CHANGELOG before finishing this one.

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.48%. Comparing base (83aa20e) to head (1cd8fed).
Report is 24 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #788      +/-   ##
===========================================
+ Coverage    76.42%   79.48%   +3.06%     
===========================================
  Files           95       96       +1     
  Lines        11090    11499     +409     
===========================================
+ Hits          8475     9140     +665     
+ Misses        2615     2359     -256     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gui-FernandesBR Gui-FernandesBR merged commit 9407470 into RocketPy-Team:develop Mar 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Bug Report: Parachute AGL altitude doesn't account for given lag
2 participants