Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: update flight simulation logic to include burn start time #778

Merged
merged 2 commits into from
Mar 4, 2025
Merged

BUG: update flight simulation logic to include burn start time #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe3a243
BUG: update flight simulation logic to include burn start time in con…
Gui-FernandesBR Mar 4, 2025
4d5339e
DEV: updates changelog
Gui-FernandesBR Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Attention: The newest changes should be on top -->

### Fixed

-
- BUG: update flight simulation logic to include burn start time [#778](https://github.com/RocketPy-Team/RocketPy/pull/778)

## [v1.8.0] - 2025-01-20

Expand Down
4 changes: 2 additions & 2 deletions rocketpy/simulation/flight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1451,7 +1451,7 @@ def u_dot(self, t, u, post_processing=False): # pylint: disable=too-many-locals
# Determine lift force and moment
R1, R2, M1, M2, M3 = 0, 0, 0, 0, 0
# Determine current behavior
if t < self.rocket.motor.burn_out_time:
if self.rocket.motor.burn_start_time < t < self.rocket.motor.burn_out_time:
# Motor burning
# Retrieve important motor quantities
# Inertias
Expand Down Expand Up @@ -1788,7 +1788,7 @@ def u_dot_generalized(self, t, u, post_processing=False): # pylint: disable=too
speed_of_sound = self.env.speed_of_sound.get_value_opt(z)
free_stream_mach = free_stream_speed / speed_of_sound

if t < self.rocket.motor.burn_out_time:
if self.rocket.motor.burn_start_time < t < self.rocket.motor.burn_out_time:
drag_coeff = self.rocket.power_on_drag.get_value_opt(free_stream_mach)
else:
drag_coeff = self.rocket.power_off_drag.get_value_opt(free_stream_mach)
Expand Down