Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: new comparison plot #714

Merged
merged 2 commits into from
Oct 30, 2024
Merged

DOC: new comparison plot #714

merged 2 commits into from
Oct 30, 2024

Conversation

Gui-FernandesBR
Copy link
Member

Pull request type

  • ReadMe, Docs and GitHub updates

Checklist

  • Docs have been reviewed and added / updated

New behavior

Fixed a few errors from what I saw on readthedocs, and also added the following picture:

image

Breaking change

  • No

@Gui-FernandesBR Gui-FernandesBR added the Docs Docs and examples related label Oct 19, 2024
@Gui-FernandesBR Gui-FernandesBR self-assigned this Oct 19, 2024
@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner October 19, 2024 19:38
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.88%. Comparing base (eb3ad14) to head (13e66f6).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #714      +/-   ##
===========================================
- Coverage    75.93%   75.88%   -0.05%     
===========================================
  Files           99       99              
  Lines        11222    11222              
===========================================
- Hits          8521     8516       -5     
- Misses        2701     2706       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@LUCKIN13 LUCKIN13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comparison plot is indeed a great addition to the documentation.
Nothing more to add.

@Gui-FernandesBR Gui-FernandesBR changed the base branch from master to develop October 29, 2024 21:24
@Gui-FernandesBR Gui-FernandesBR merged commit 3958d28 into develop Oct 30, 2024
8 of 9 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the doc/new-comparison-plot branch October 30, 2024 06:16
@Gui-FernandesBR Gui-FernandesBR linked an issue Nov 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Docs and examples related
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

DOC: duplicated github button on docs page
2 participants