-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Refactor Tank's testing Assertion with CAD data. #678
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #678 +/- ##
===========================================
+ Coverage 75.99% 76.43% +0.44%
===========================================
Files 95 95
Lines 11015 11078 +63
===========================================
+ Hits 8371 8468 +97
+ Misses 2644 2610 -34 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few tests are not passing locally...
def test_all_info(mock_show, flight_calisto_robust): # pylint: disable=unused-argument
def test_motor(mock_show, cesaroni_m1670): # pylint: disable=unused-argument
Thanks for testing it. I will check what is happening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
Currently the Tank's testing module present the following issues:
New behavior
This PR aims to bring the following changes to code:
cadquery
module for geometrical validation;Breaking change
Additional information
Check out CadQuery docs for further information and examples.
An important notice is that the CAD module is not executed in every test for the two reasons:
Therefore I have added the necessary code into a Jupyter notebook for easy recalculation of the expected values, but this can be discussed further on this PR.
P.S.: I will fix the PyLint errors shortly.