Skip to content

Conversation

@MateusStano
Copy link
Member

@MateusStano MateusStano commented May 23, 2024

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Prandtl-Glauert transformation is only applied to Fins. This was done because on https://ntrs.nasa.gov/citations/20010047838, Barrowman only applies it to fins

New behavior

Prandtl-Glauert transformation is now also applied to NoseCone and Tail. This is done because Barrowman does in a more recent paper: https://arc.aiaa.org/doi/10.2514/6.1979-504

Breaking change

  • Yes
  • No

@MateusStano MateusStano requested a review from a team as a code owner May 23, 2024 20:37
@codecov
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.60%. Comparing base (54c69a3) to head (158d1ca).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #609      +/-   ##
===========================================
- Coverage    73.64%   73.60%   -0.05%     
===========================================
  Files           73       70       -3     
  Lines        10307    10290      -17     
===========================================
- Hits          7591     7574      -17     
  Misses        2716     2716              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateusStano MateusStano changed the title ENH: Add Prandtl-Gauss transformation to NoseCone and Tail ENH: Add Prandtl-Glauert transformation to NoseCone and Tail May 23, 2024
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is really good, simple and effective.

My only "strong suggestion" is: can you include your references in the code? I remember I read the first document you shared in your PR description and I got the impression we shouldn't add the beta correction. Now I understand it.

This PR will close the following issue: #133

@Gui-FernandesBR Gui-FernandesBR added the Enhancement New feature or request, including adjustments in current codes label May 25, 2024
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone May 25, 2024
@Gui-FernandesBR Gui-FernandesBR linked an issue May 25, 2024 that may be closed by this pull request
@Gui-FernandesBR Gui-FernandesBR self-requested a review June 13, 2024 13:57
@MateusStano MateusStano merged commit 9322646 into develop Jun 13, 2024
@MateusStano MateusStano deleted the enh/add-prandtl-nosecone-tail branch June 13, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request, including adjustments in current codes

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

ENH: Variation of CL with Mach (nose and tail)

3 participants