-
-
Notifications
You must be signed in to change notification settings - Fork 206
ENH: Add Prandtl-Glauert transformation to NoseCone and Tail #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #609 +/- ##
===========================================
- Coverage 73.64% 73.60% -0.05%
===========================================
Files 73 70 -3
Lines 10307 10290 -17
===========================================
- Hits 7591 7574 -17
Misses 2716 2716 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is really good, simple and effective.
My only "strong suggestion" is: can you include your references in the code? I remember I read the first document you shared in your PR description and I got the impression we shouldn't add the beta correction. Now I understand it.
This PR will close the following issue: #133
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
Prandtl-Glauert transformation is only applied to
Fins. This was done because on https://ntrs.nasa.gov/citations/20010047838, Barrowman only applies it to finsNew behavior
Prandtl-Glauert transformation is now also applied to
NoseConeandTail. This is done because Barrowman does in a more recent paper: https://arc.aiaa.org/doi/10.2514/6.1979-504Breaking change