Skip to content

ENH: A more intuitive deployable payload flight example #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 69 commits into from

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Sep 24, 2022

Pull request type

  • Code base additions (bugfix, features)

Pull request checklist

  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

Currently we don't have examples of simulations for flying rockets with medium-high complexity. It's really bothers me that we all know how would it be to perform such simulations, but we have never done and shared before. Let's change that scenario.

What is the new behavior?

Here a list of simulations that we are lacking in terms of example usage:

  • Add example simulation of a rocket with Deployable Payload Flight

Does this introduce a breaking change?

  • Yes
  • No

@Gui-FernandesBR Gui-FernandesBR added Enhancement New feature or request, including adjustments in current codes Docs Docs and examples related Controllers Controlling rocket flight methods labels Sep 24, 2022
@Gui-FernandesBR Gui-FernandesBR self-assigned this Sep 24, 2022
@Gui-FernandesBR
Copy link
Member Author

Well, I realized today that I've made several mistakes in this branch. After some workaround I'm really close to a newer stable version of the code that is present here.
Status: Flight.py file is still not updated with current develop version. Work in Progress on that.

@Gui-FernandesBR Gui-FernandesBR changed the title WIP: Complex simulations examples ENH: A more intuitive deployable payload flight example Nov 12, 2022
@Gui-FernandesBR
Copy link
Member Author

The #322 will address this PR in a much more efficient way. Stay tuned for that

@Gui-FernandesBR Gui-FernandesBR removed this from the Release v1.0.0 milestone Jan 11, 2023
@Gui-FernandesBR Gui-FernandesBR deleted the enh/complex_simulations branch October 14, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Controllers Controlling rocket flight methods Docs Docs and examples related Enhancement New feature or request, including adjustments in current codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants