Conversation
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
@gilmarsquinelato nice code! but I think we have some problems :x.
- we are creating users without usernames(you can create one more screen asking for username, like the web client or use the REST API that accept username as param)
- if the creation returns ok we are redirect to login, you can get the token access by the success of method and redirect to home.
|
@ggazzo Thanks for the feedback, I'll make the changes :) |
Codecov Report
@@ Coverage Diff @@
## develop #44 +/- ##
======================================
Coverage 100% 100%
======================================
Files 6 6
Lines 44 44
Branches 9 9
======================================
Hits 44 44Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #44 +/- ##
======================================
Coverage 100% 100%
======================================
Files 6 6
Lines 44 44
Branches 9 9
======================================
Hits 44 44Continue to review full report at Codecov.
|
- logo removed from logo and register
app/sagas/login.js
Outdated
| yield takeEvery(types.LOGIN.REQUEST, handleLoginRequest); | ||
| yield takeEvery(types.LOGIN.SUCCESS, saveToken); | ||
| yield takeEvery(types.LOGIN.SUBMIT, handleLoginSubmit); | ||
| yield takeEvery(types.LOGIN.REGISTER_REQUEST, handleRegisterRequest); |
app/sagas/rooms.js
Outdated
| }; | ||
| const root = function* root() { | ||
| yield takeEvery(types.LOGIN.SUCCESS, watchRoomsRequest); | ||
| yield takeEvery(types.ROOMS.REQUEST, watchRoomsRequest); |
There was a problem hiding this comment.
you should call roomsRequest in some place :)
- getRooms request
* Added feature to register a new user * login after register working * Removed username from register and placed on a new view * loading indicator on username submit * register/username logo layout issue * - login and register background white * - logo removed from logo and register
4 participants
Created a component with fields Name, Email and password.
Created actions to receive the user data and dispatch to rocketchat lib to create user.