Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocket.Chat 4.0.0 Desktop Client crashes on rootWindow.addListener('close', ...) when isTrayIconEnabled === false && process.platform === 'linux' #2906

Open
2 of 5 tasks
VeldoraTheDragon opened this issue Jun 17, 2024 · 2 comments

Comments

@VeldoraTheDragon
Copy link

VeldoraTheDragon commented Jun 17, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Operating System

  • macOS
  • Windows
  • Linux

Operating System Version

Arch Linux

It happens on the web browser too?

No, it just happens on the Desktop app

Rocket.Chat Desktop App Version

4.0.0

Rocket.Chat Server Version

6.7

Describe the bug

When closing via X-Icon while the tray-icon has been disabled, the app crashes with the following message:

Uncaught Exception:
TypeError: Object has been destroyed
  at /opt/Rocket.Chat/resources/app.asar/app/main.js:2095:18
  at /opt/Rocket.Chat/resources/app.asar/app/main.js:2178:43
  at Array.forEach (<anonymous>)
  at App.<anonymous> (/opt/Rocket.Chat/resources/app.asar/app/main.js:2178:19)
  at App.emit (node:events:526:35)
  at App.emit (node:domain:488:12)
  at App.<anonymous> (/opt/Rocket.Chat/resources/app.asar/app/main.js:2432:18)
  at App.emit (node:events:526:35)
  at App.emit (node:domain:488:12)

Closing via Ctrl + Q or File => Quit Rocket.Chat doesn't trigger the error.

How to Reproduce

  1. Go to settings
  2. disable Tray Icon
  3. Close via X

Describe your Expected behavior

The app should close like the other methods, without error.

Anything else

I've unpacked the app.asar and opened the affected file on the described line.
It shows me the following line:

The other methods utilize app.quit() as seen in.

id: 'quit',
label: t('menus.quit', { appName: app.name }),
accelerator: 'CommandOrControl+Q',
click: () => {
app.quit();

Are you willing to submit a code contribution?

  • Yes, I am willing to submit a Pull Request!
@VeldoraTheDragon VeldoraTheDragon changed the title Rocket.Chat 4.0.0 Desktop Client crashes on rootWindow.addListener('close', ...) when isTrayIconEnabled === false && process.platform === 'linux' Rocket.Chat 4.0.0 Desktop Client crashes on rootWindow.addListener('close', ...) when isTrayIconEnabled === false && process.platform === 'linux' Jun 17, 2024
@Vringe
Copy link

Vringe commented Jul 24, 2024

Same here with Arch and V4.0.1

@juluanb
Copy link

juluanb commented Oct 30, 2024

Same here with Ubuntu 22.04.5 LTS and V4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants