Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

feat: Extend typing capability for threads #638

Open
wants to merge 2 commits into
base: alpha
Choose a base branch
from

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 7, 2023

What? β›΅

Why? πŸ€”

Links 🌎

PS πŸ‘€

@ggazzo ggazzo marked this pull request as ready for review June 9, 2023 04:54
@casalsgh casalsgh requested review from a team and d-gubert June 12, 2023 19:19
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this is a breaking change, since the type TypingScope has been removed and the parameter for the typing function has changed. It will cause developers who try to update their apps with the latest compatible version to face an unexpected error while packaging the app. For these changes to go forward as they are, it needs to go in a major update of the Framework or be adapted to be compatible with the current type definitions

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

βœ… ggazzo
❌ casalsgh
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants