Skip to content

Integrated support for Gazebo clock and use_sim_time #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2023

Conversation

evan-palmer
Copy link
Collaborator

@evan-palmer evan-palmer commented Jul 15, 2023

Checklist

  • I have performed a thorough review of my code
  • I have sufficiently commented my code
  • The implementation follows the project style conventions
  • All project unit tests are passing
  • If relevant, documentation has been provided or updated to discuss the changes made
  • System integration tests were performed successfully

Changes Made

This PR introduces support for using the Gazebo clock as the system clock. This makes it possible for folks to now use either the Gazebo clock or the system clock according to their needs. Furthermore, this PR improves the modularity of the launch files to make it easier to integrate support for new models and modify the configurations of existing models. I also removed Foxglove "support". This project doesn't have any particular configuration files for visualization, so this isn't really a feature. Additionally, it requires users to install an external package that the may not need or want.

Associated Issues

Testing

Regression testing was performed using SITL.

@evan-palmer evan-palmer self-assigned this Jul 15, 2023
@evan-palmer evan-palmer linked an issue Jul 15, 2023 that may be closed by this pull request
@evan-palmer evan-palmer merged commit b4c86cc into main Jul 15, 2023
@evan-palmer evan-palmer deleted the 48-feature-implement-use_sim_time-argument branch July 15, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Implement use_sim_time argument [FEATURE]: Improve launch description modularity
1 participant